Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate alias.go #1484

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Deprecate alias.go #1484

merged 2 commits into from
Jul 6, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Jul 5, 2023

Resolves #1456

@pinosu pinosu requested a review from alpe as a code owner July 5, 2023 11:20
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Merging #1484 (5bf3b93) into main (1763477) will not change coverage.
The diff coverage is 85.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   57.86%   57.86%           
=======================================
  Files          63       63           
  Lines        8344     8344           
=======================================
  Hits         4828     4828           
  Misses       3112     3112           
  Partials      404      404
Impacted Files Coverage Δ
app/test_support.go 0.00% <0.00%> (ø)
x/wasm/module.go 36.56% <58.33%> (ø)
app/app.go 86.30% <100.00%> (ø)
app/test_helpers.go 62.84% <100.00%> (ø)
x/wasm/ibc.go 68.36% <100.00%> (ø)

alpe
alpe reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this tasks. A lot of work 🥇
Can you bring back the alias.go and make everything deprecated there? We would delete it with the next version.
Some people may use wamd as a library and this would help them with a softer transition. 🙏

alpe
alpe approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very rewarding but important work! Thank you for doing this!

@alpe alpe merged commit 0fd9ecd into main Jul 6, 2023
@faddat faddat mentioned this pull request Jul 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate alias.go
2 participants
@pinosu @alpe